chore: move api into dependencies in integration tests #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests require the OTel API. Therefore move it into dependencies section and remove the peer-dependency.
Flarna
requested review from
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rauno56 and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2385 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 145 145
Lines 5226 5226
Branches 1071 1071
=======================================
Hits 4849 4849
Misses 377 377 |
|
EasyCLA tells I miss CLA authorization. No idea what I did that this got lost. If I click on above link to get authorized the result is an internal server error. Any hints welcome... |
dyladan
approved these changes
Aug 2, 2021
|
I'm not sure what's wrong with the CLA check. I'll try to find out more |
|
@Flarna looks like the email associated with that commit is a yahoo.de email. Most of your other commits appear to use the |
|
/easycla |
MSNev
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests require the OTel API. Therefore move it into dependencies section and remove the peer-dependency.